Sudhakar Rajashekhara <[EMAIL PROTECTED]> writes:
> Description:
> Adds dm6467 support to I2C driver.
> Signed-off-by: Sudhakar Rajashekhara <[EMAIL PROTECTED]>
Minor correction: You don't need the 'Description:' header, just the
description text. Also, add an empty line before the signoff please.
> arch/arm/mach-davinci/devices.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/devices.c b/arch/arm/mach-davinci/devices.c
> index 2fcbc2e..99eed0c 100644
> --- a/arch/arm/mach-davinci/devices.c
> +++ b/arch/arm/mach-davinci/devices.c
> @@ -19,6 +19,7 @@
> #include <asm/io.h>
> #include <asm/mach-types.h>
> #include <asm/mach/map.h>
> +#include <asm/arch/i2c.h>
>
> #if defined(CONFIG_I2C_DAVINCI) || defined(CONFIG_I2C_DAVINCI_MODULE)
>
> @@ -34,15 +35,24 @@ static struct resource i2c_resources[] = {
> },
> };
>
> +static struct davinci_i2c_platform_data dm646x_i2c_data = {
> + .bus_freq = 100,
> + .bus_delay = 0,
> +};
> +
> static struct platform_device davinci_i2c_device = {
> .name = "i2c_davinci",
> .id = 1,
> + .dev = {
> + .platform_data = &dm646x_i2c_data,
> + },
> .num_resources = ARRAY_SIZE(i2c_resources),
> .resource = i2c_resources,
> };
>
> static void davinci_init_i2c(void)
> {
> + davinci_i2c_device.dev.platform_data = &dm646x_i2c_data;
> (void) platform_device_register(&davinci_i2c_device);
Are these settings chip specific or board specific? Either way, this
code should be conditionalized. The way it is coded now, the struct
is named dm646x, but it is used on all platforms.
We really need the equivalent of the omap_register_i2c_bus() here.
> }
>
> --
> 1.5.4.1
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> [email protected]
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
