> From: Lloyd Sargent
> > Index: linux-davinci-2.6/drivers/net/davinci_emac.c
> > ===================================================================
> > --- linux-davinci-2.6.orig/drivers/net/davinci_emac.c
> > +++ linux-davinci-2.6/drivers/net/davinci_emac.c
> > @@ -361,8 +361,8 @@ struct emac_netbufobj { struct emac_netpktobj {
> > void *pkt_token; /* data token may hold tx/rx chan id */
> > struct emac_netbufobj *buf_list; /* array of network
> buffer objects */
> > - int num_bufs; /* number of network buffer objects */
> > - int pkt_length; /* packet length (number of bytes) */
> > + int num_bufs;
> > + int pkt_length;
> Had you really wanted to IMPROVE the code, perhaps changing
> "num_bufs"
> to "numberOfNetworkBufferObjects" and then adding
> documentation throughout the code would have been better.
I doubt you have had many mainline patches approved with this kind of
huge camelcase variable name. It may be acceptable in some kinds of
programming but not kernel C.
Personally I found the patch to remove the comments entirely reasonable.
The only information we lose is that they are *network* buffers and that
they are *objects*. Both pieces of information that are clear from the
context.
I applaud people who can write code as concise and clear as this. I wish
I were so skilled.
--
Jon Povey, Design Engineer
[EMAIL PROTECTED] | +44(0)1280 825983
Racelogic is a limited company registered in England. Registered number 2743719
.
Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks,
MK18 1TB .
The information contained in this electronic mail transmission is intended by
Racelogic Ltd for the use of the named individual or entity to which it is
directed and may contain information that is confidential or privileged. If you
have received this electronic mail transmission in error, please delete it from
your system without copying or forwarding it, and notify the sender of the
error by reply email so that the sender's address records can be corrected. The
views expressed by the sender of this communication do not necessarily
represent those of Racelogic Ltd. Please note that Racelogic reserves the right
to monitor e-mail communications passing through its network
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
