Sergei, I'll address this in my next set of patches.
Regards, Sudhakar ________________________________________ From: Sergei Shtylyov [EMAIL PROTECTED] Sent: Sunday, September 14, 2008 7:31 PM To: Rajashekhara, Sudhakar Cc: [email protected] Subject: Re: [PATCH v4 09/10] ARM: DaVinci: serial mis-behavior on dm6467 Sudhakar Rajashekhara wrote: > Fixes UART mis-behavior on dm6467. > Signed-off-by: Sudhakar Rajashekhara <[EMAIL PROTECTED]> > diff --git a/arch/arm/mach-davinci/board-dm6467-evm.c > b/arch/arm/mach-davinci/board-dm6467-evm.c > index 03cd7d1..8867a56 100644 > --- a/arch/arm/mach-davinci/board-dm6467-evm.c > +++ b/arch/arm/mach-davinci/board-dm6467-evm.c > @@ -64,6 +64,20 @@ static void __init evm_init_i2c(void) > davinci_init_i2c(&i2c_pdata); > } > > +#define UART_DM6467_SCR __REG(DAVINCI_UART0_BASE + 0x40) > +/* > + * Internal UARTs need to be initialized for the 8250 autoconfig to work > + * properly. Note that the TX watermark initialization may not be needed > + * once the 8250.c watermark handling code is merged. > + */ > +static int __init dm646x_serial_reset(void) > +{ > + UART_DM6467_SCR = 0x08; Please don't use the assignment operator to write registers. Use the I/O accessors -- like davinci_writel(). WBR, Sergei_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
