On Monday 08 December 2008, Felipe Balbi wrote: > From: Felipe Balbi <[EMAIL PROTECTED]> > > Lot's of cleanups to davinci_nand.c: > > - convert printk() to dev_err() > - get control base via struct resource > - add missing static and __init > - remove some useless ifdef > - add some REVISIT notes for later patches > - add locking support for register access operations > > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]>
I suggest some patch splitting ... e.g. the control base bits with their resource updates (updated patch #1), the mostly-cosmetic bits (dev-err, static/__init, #ifdef, and I see whitespace updates too), introducing davinci_nand_info (not even mentioned above!), and so on. It'd make it easier to review. This one's kind of all over the map... - Dave _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
