On Wednesday 17 December 2008, Rajashekhara, Sudhakar wrote:
> Dave,
> 
> > @@ -127,6 +196,15 @@ void davinci_psc_config(unsigned int dom
> > 
> >  void __init davinci_psc_init(void)
> >  {
> > +       if (cpu_is_davinci_dm644x()) {
> > +               davinci_psc_mux = dm6446_psc_mux;
> > +       } else if (cpu_is_davinci_dm355()) {
> > +               davinci_psc_mux = dm355_psc_mux;
> > +       } else {
> > +               pr_err("PSC: no PSC mux hooks for this CPU\n");
> > +               davinci_psc_mux = nop_psc_mux;
> > +       }
> > +
> 
> davinci_psc_init is not being called for DM646x EVM, hence
> davinci_psc_mux is not defined for DM646x. This is resulting
> in DM646x board not booting up. I'll submit a patch to fix this.

Understandable.  I didn't know what the 646x chips need.
Did you not even see that "no PSC mux hooks" message?


> >          davinci_psc_config(DAVINCI_GPSC_ARMDOMAIN, DAVINCI_LPSC_VPSSMSTR, 
> > 1);
> >          davinci_psc_config(DAVINCI_GPSC_ARMDOMAIN, DAVINCI_LPSC_VPSSSLV, 
> > 1);
> >          davinci_psc_config(DAVINCI_GPSC_ARMDOMAIN, DAVINCI_LPSC_TPCC, 1);
> 
> The above configurations will hold good only for DM644x and DM355.
> So they need to be guarded by cpu_is_davinci_*** macros. 

Actually all of that always "turn these clocks on" stuff seems
pretty dubious to me.  I didn't touch it here though.

Glad some one with 646x can start taking a closer look at such
stuff, and fixing the issues.

- Dave


> 
> Regards, Sudhakar
> 



_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to