On Tue, 6 Jan 2009 21:31:17 +0000 Mark Brown <[email protected]> wrote:
> On Tue, Jan 06, 2009 at 04:23:45PM -0500, Hugo Villeneuve wrote: > > The SFFSDR audio codec sampling frequency clock is generated by > > a FPGA, and set by the FPGA driver. The FPGA driver is not yet > > in the mainline kernel, so that is why an extern declaration is > > used in the meantime. > > > Signed-off-by: Hugo Villeneuve <[email protected]> > > If the driver is for is not yet in mainline I'd be more inclined to > fix this by providing the relevant Kconfig dependency to exclude it > from the build rather than changing the C file - the dependency will > be needed anyway when the FPGA driver is in mainline. Hi Mark, The problem is that some people may want to do modifications to this soc driver, and they won´t be able to test that their changes are valid (ex: do not break compilation). > Do the DaVinci drivers build at all in mainline, anyway? Last time I > checked they required out of tree DMA patches. I just sucessfully compiled the davinci-sffsdr soc driver (although audio seems broken for me at the moment when I actually test it). Hugo V. --------------- Hugo Villeneuve www.hugovil.com --------------- _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
