For some strange reason musb_giveback() decides that it's always IN transfer in case the hardware endpoint has shared FIFO. This causes musb_save_toggle() to read the toggle state from the RXCSR register instead of TXCSR; it also may cause unneeded reloading of the Rx endpoint registers.
Signed-off-by: Sergei Shtylyov <[email protected]> --- The patch is against the recent Linus' kernel. drivers/usb/musb/musb_host.c | 7 +------ 1 files changed, 1 insertion(+), 6 deletions(-) Index: linux-2.6/drivers/usb/musb/musb_host.c =================================================================== --- linux-2.6.orig/drivers/usb/musb/musb_host.c +++ linux-2.6/drivers/usb/musb/musb_host.c @@ -335,16 +335,11 @@ musb_save_toggle(struct musb_hw_ep *ep, static struct musb_qh * musb_giveback(struct musb_qh *qh, struct urb *urb, int status) { - int is_in; struct musb_hw_ep *ep = qh->hw_ep; struct musb *musb = ep->musb; + int is_in = usb_pipein(urb->pipe); int ready = qh->is_ready; - if (ep->is_shared_fifo) - is_in = 1; - else - is_in = usb_pipein(urb->pipe); - /* save toggle eagerly, for paranoia */ switch (qh->type) { case USB_ENDPOINT_XFER_BULK: _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
