On Thu, 2009-02-12 at 15:24 +0530, Subrahmanya, Chaithrika wrote: > > On Wed, 2009-02-11 at 11:34 +0530, Subrahmanya, Chaithrika wrote: > > > > > > > > > > > Also, it helps tell the driver to not care about any connected PHY > > (by setting the > > > mask to 0). The OMAP-L137 EVM has a switch connected to the MAC > > instead > > > of a PHY. In that case, most likely, mask value of zero will be used. > > > > We should be able to read the device id and make decisions based on > > device id. Will that be preferred over hard coded values? > > Are you referring to the cpu_is_xxx( ) macro, to get the device id info?
No, I'm referring to the PHY device ID. Not the SOC JTAG ID which is checked by cpu_is_xxx macro. > The PHY type being used is board specific and not SoC specific. > Adding a device id verification code for each EVM/board may make > the driver code more difficult to handle as the number of boards increase. This is something we both agree. In fact, any drivers that uses the cpu_is_xxx macros is probably wrong. Regards, Steve _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
