On Friday 20 February 2009, Felipe Balbi wrote: > On Fri, Feb 20, 2009 at 02:07:58PM -0800, David Brownell wrote: > > On Friday 20 February 2009, Felipe Balbi wrote: > > > On Fri, Feb 20, 2009 at 01:45:17PM -0800, David Brownell wrote: > > > > @@ -116,7 +116,7 @@ > > > > > > > > unsigned musb_debug; > > > > module_param(musb_debug, uint, S_IRUGO | S_IWUSR); > > > > -MODULE_PARM_DESC(debug, "Debug message level. Default = 0"); > > > > +MODULE_PARM_DESC(musb_debug, "Debug message level. Default = 0"); > > > > > > we could actually use module_param_named(debug, musb_debug, ....); > > > > I was just making the existing interface work right, > > not trying to change anything. > > Yeah sure, that was more like a note than a comment to the patch itself > ;-) > > Anyways, here's the patch changing to module_param_named() on top of > this one: > > ========== cut here ========== > >From 85e17a9284734ce281bda3407a0286caf323f5db Mon Sep 17 00:00:00 2001 > From: Felipe Balbi <[email protected]> > Date: Sat, 21 Feb 2009 00:12:14 +0200 > Subject: [PATCH] usb: musb: use module_param_named > > Change modprobe musb_hdrc musb_debug=3 to > modprobe musb_hdrc debug=3. > > Signed-off-by: Felipe Balbi <[email protected]>
OK by me, even if Greg wants to merge this with the $SUBJECT patch. > --- > drivers/usb/musb/musb_core.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 3026d4f..b165581 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -115,8 +115,8 @@ > > > unsigned musb_debug; > -module_param(musb_debug, uint, S_IRUGO | S_IWUSR); > -MODULE_PARM_DESC(musb_debug, "Debug message level. Default = 0"); > +module_param_named(debug, musb_debug, uint, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(debug, "Debug message level. Default = 0"); > > #define DRIVER_AUTHOR "Mentor Graphics, Texas Instruments, Nokia" > #define DRIVER_DESC "Inventra Dual-Role USB Controller Driver" > -- > 1.6.1.3 > > -- > balbi > > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
