Hello, I wrote:
Signed-off-by: Kevin Hilman <[email protected]>
diff --git a/arch/arm/mach-davinci/include/mach/mux.h
b/arch/arm/mach-davinci/include/mach/mux.h
index 497f540..41be141 100644
--- a/arch/arm/mach-davinci/include/mach/mux.h
+++ b/arch/arm/mach-davinci/include/mach/mux.h
@@ -22,19 +22,19 @@
#include <mach/dm644x.h>
/* System module registers */
-#define PINMUX0 (DAVINCI_SYSTEM_MODULE_BASE + 0x00)
-#define PINMUX1 (DAVINCI_SYSTEM_MODULE_BASE + 0x04)
+#define PINMUX0 0x00
+#define PINMUX1 0x04
/* dm355 only */
-#define PINMUX2 (DAVINCI_SYSTEM_MODULE_BASE + 0x08)
-#define PINMUX3 (DAVINCI_SYSTEM_MODULE_BASE + 0x0c)
-#define PINMUX4 (DAVINCI_SYSTEM_MODULE_BASE + 0x10)
-#define INTMUX (DAVINCI_SYSTEM_MODULE_BASE + 0x18)
-#define EVTMUX (DAVINCI_SYSTEM_MODULE_BASE + 0x1c)
+#define PINMUX2 0x08
+#define PINMUX3 0x0c
+#define PINMUX4 0x10
That wasn't really a good change from the point of view of
OMAP-L137...
I'm not sure how this simple rename isn't good for the OMAP-L137.
It's not at all a "simple rename". :-/
If anything, the goal is to make the code use 'base + offset' instead
of hard-coded physical
addresses which is more suitable for runtime configuring of base
address.
It turns t be less suitable, actually. Because with the old scheme, you
wouldn't have to runtime-configure anything *at all* WRT the PinMux.
Any device specific offsets that are different from these can
be defined
as <device>_PINMUXN.
Well, they have to be in any case... anyway, it's already solved by
Mark.
Er, not yet... you've changed the 'mux_reg' field of 'struct mux_config'
to 'unsigned char' but that won't suffice for DA830 where the registers
offsets start at 0x120.
moreover, it introduced a bug. :-/
Can you be even slightly more specific.
Remember the recent patch changing cfg->reg to cfg->mask in
cfg->mux_reg, to be precise...
davinci_cfg_reg()? It was fixing a fallout of your "simple rename". :-)
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
