David, Thanks.
Agreed. I will change in the next patch set. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: [email protected] >>>-----Original Message----- >>>From: David Brownell [mailto:[email protected]] >>>Sent: Saturday, March 14, 2009 1:54 PM >>>To: [email protected] >>>Cc: Karicheri, Muralidharan; [email protected] - PSP >>>DaVinci Open Source CCB (May contain non-TIers); [email protected] - >>>Video discussion list for PSP Video team (May contain non-TIers) >>>Subject: Re: [PATCH 4/7] ccdc hw module and header file for DM6446 >>> >>>On Friday 13 March 2009, [email protected] wrote: >>>> drivers/media/video/ccdc_davinci.c | 124 ---- >>> >>>This file isn't in mainline or any v4l tree I've seen ... >>> >>> >>>> drivers/media/video/davinci/ccdc_davinci.c | 1007 >>>++++++++++++++++++++++++++++ >>>> drivers/media/video/davinci/ccdc_davinci.h | 335 +++++++++ >>> >>>I suggest naming this "ccdc_dm644x.[hc]". >>> >>>DaVinci is a family, not a single chip; >>>and you used "ccdc_dm355.[hc]" for one of >>>the other chips in the family... >>> >>> >>>> include/media/ccdc_davinci.h | 144 ---- >>> >>> _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
