On 26-03-09 22:54, Kevin Hilman wrote:
Koen Kooi<[email protected]>  writes:

The dm355 leopard board is meant to be a low-cost IP netcam. It has
ethernet, USB OTG and SD support, as well as the ability to use
different sensor boards.
It is being promoted as "beagle buddy" to be used as a companion to the
OMAP3 beagleboard.

Signed-off-by: Koen Kooi<[email protected]>

A couple checkpatch errors, which are probably inherited, but still
should be fixed:

ERROR: trailing whitespace
#62: FILE: arch/arm/mach-davinci/board-dm355-leopard.c:6:
+ * This file is licensed under the terms of the GNU General Public $

OK, that one has been fixed.

WARNING: line over 80 characters
#256: FILE: arch/arm/mach-davinci/board-dm355-leopard.c:200:
+       return !gpio_get_value_cansleep(dm355leopard_mmc_gpios + 2 * module + 
1);

I'm unsure how to tackle that one, it's 81 chars (for 8 space tabs) and I don't see a good place to split it that wouldn't make is less readable. Do you have any suggestions where to split it? I'm slightly tempted to just rename dm355leopard_mmc_gpios to leopard_mmc_gpios :)

regards,

Koen


_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to