On Tue, Mar 31, 2009 at 05:34:36PM -0700, Kevin Hilman wrote: > "Mark A. Greer" <[email protected]> writes: > > > On Mon, Mar 30, 2009 at 10:35:10PM -0700, Kevin Hilman wrote: > >> "Mark A. Greer" <[email protected]> writes: > > > >> > diff --git a/arch/arm/mach-davinci/common.c > >> > b/arch/arm/mach-davinci/common.c > >> > index 902d677..df57273 100644 > >> > --- a/arch/arm/mach-davinci/common.c > >> > +++ b/arch/arm/mach-davinci/common.c > >> > @@ -64,6 +64,9 @@ int __init davinci_common_init(struct davinci_soc_info > >> > *soc_info) > >> > local_flush_tlb_all(); > >> > flush_cache_all(); > >> > > >> > >> A comment here with a summary of description above would be a helpful > >> reminder so we don't blindly move this to a different "early" spot > >> later on. > > > > I copied the comment for this snippet of code from io.c. Is that not > > sufficient? > > Sorry, my comment was in the wrong spot. > > I meant a comment about the importance of the location of the > ->early_init hook.
Okay. FYI, in an out-of-band discussions with TI we concluded that I really shouldn't be touching the kick regs so I don't need that hook anymore. Mark -- _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
