On Friday 03 April 2009, Jorge Luis Zapata Muga wrote:
> @@ -27,6 +28,17 @@ static struct davinci_uart_config
> ntosd_644xa_uart_config __initdata = {
Looks like there are linewrap problems ...
> .enabled_uarts = (1 << 0),
> };
>
> +/*******************************************************************************
> + * NET
> *
.... as well as lines that are too long ...
> +
> ******************************************************************************/
> +#define NTOSD_644XA_PHY_MASK (0x2)
> +#define NTOSD_644XA_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> +
> +static struct emac_platform_data ntosd_644xa_emac_pdata = {
> + .phy_mask = NTOSD_644XA_PHY_MASK,
> + .mdio_max_freq = NTOSD_644XA_MDIO_FREQUENCY,
There's not much point to #defines for constants like those,
which are used exactly once for assignment to names which are
already self-documenting.
> +};
> +
> static void __init ntosd_644xa_map_io(void)
> {
> davinci_map_common_io();
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
