From: Kevin Hilman [mailto:[email protected]] Sent: Monday, April 13, 2009 10:41 PM > > [email protected] writes: > > > From: Steve Chen <[email protected]> > > > > The skb data allocated for packet data received is 4 byte aligned. > > > > Unfortunately, this causes non-32bit aligned accesses in IP stack > because > > the MAC header is non-word aligned (14 bytes). > > > > The result can be observed by looking at /proc/cpu/alignment while > the > > device is over network. > > > > This issue is resolved by using a 2-byte extra offset in the packet > buffer. > > > > A quick performance test over lab network using iperf on DM6446 EVM > showed > > an increase in bandwidth from 60Mbits/s to 70Mbits/s. > > > > Signed-off-by: Steve Chen <[email protected]> > > Signed-off-by: Sekhar Nori <[email protected]> > > Nori, > > What are the plans to submit this driver to netdev? I'd like to see > this driver submitted upstream and thes kinds of issues being sorted > out on the netdev list.
Yes, this has been pending for long time. There are two patches (this and the one from Stephen Irons) both of which fix issues of driver interaction with netdev layer. I guess submission to netdev will require both of these to be fixed anyway. How about absorbing these two patches (in their acceptable form) and then Chaithrika goes ahead and submits the emac driver patch to netdev ML? > > Also, I thought you were planning to use NET_IP_ALIGN? > Yes. I need to rework the patch. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
