"Mark A. Greer" <[email protected]> writes: > On Mon, Apr 13, 2009 at 02:30:49PM -0700, Kevin Hilman wrote: >> "Mark A. Greer" <[email protected]> writes: > >> > #define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000 >> > #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000 >> > @@ -189,8 +190,13 @@ static struct davinci_uart_config uart_config >> > __initdata = { >> > >> > static void __init dm355_evm_map_io(void) >> > { >> > - davinci_map_common_io(); >> > - dm355_init(); >> > + int ret; >> > + >> > + ret = davinci_common_init(&davinci_soc_info_dm355); >> > + if (ret) >> > + pr_err("SoC Initialization failed\n"); >> > + else >> > + dm355_init(); >> >> Seems like you've had to make davinci_soc_info_<soc> global only so >> that it can be passed into common_init() from the board files. Instead, >> how about just keep the call to dm355_init(), and then, in dm355.c, call >> common_init() with the soc_info struct statically defined there. > > I need to leave the soc_info structs as globals so board code can > override things before calling <soc>_init() (e.g., default irq > priorities).
Can't board code use get_soc_info() to get a handle? Since it will have already been initialized by the SoC-specific initcall? Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
