Sergei Shtylyov <[email protected]> writes:

> Hello.
>
> Kevin Hilman wrote:
>
>>> Add support for Texas Instuments Communication Port Programming Interface 
>>> 4.1
>>> (CPPI 4.1) used on OMAP-L137/DA830.
>>>
>>> At this moment, only the DMA controller and queue manager are supported.
>>> Support for the buffer manager is lacking but this chip doesn't have it 
>>> anyway.
>>>
>>> Signed-off-by: Sergei Shtylyov <[email protected]>
>>>
>>>     
>>
>> Should I expect this to compile?
>>   
>
>   Yes, of course.
>
>>> +extern const struct cppi41_queue_mgr cppi41_queue_mgr[];
>>> +extern const struct cppi41_dma_block cppi41_dma_block[];
>>> +extern const u8 cppi41_num_queue_mgr;
>>> +extern const u8 cppi41_num_dma_block;
>>>     
>>
>> These are never defined, but are used in the code resulting in a bunch of
>> linker errors for undefined symbols.
>>   
>
>   They need to be defined by the platform code which knows how many
> DMA blocks and queue managers there are. This is something that should
> be in da830.c...

Then I suggest handling this as a platform_device with the
dependencies passed in by platform code.

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to