Russell King - ARM Linux <[email protected]> writes:

> On Tue, Apr 21, 2009 at 07:50:10AM -0700, Kevin Hilman wrote:
>>  static struct davinci_gpio chips[DIV_ROUND_UP(DAVINCI_N_GPIO, 32)];
>>  
>> +static unsigned __initdata ngpio;
>>  
>>  /* create a non-inlined version */
>>  static struct gpio_controller *__iomem __init gpio2controller(unsigned gpio)
>
> Although not added by your patch, this is wrong.
>
> static struct gpio_controller __iomem * __init gpio2controller(unsigned gpio)
>
> The '__iomem' tag should come immediately before the '*', but the function
> section placement should come between the return type and the function name.

OK, I'll add this fix to this patch.

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to