Dave,
>
> > /* PaRAM slots are laid out like this */
> > struct edmacc_param {
> > unsigned int opt;
> > @@ -171,6 +176,10 @@ enum sync_dimension {
> > ABSYNC = 1
> > };
> >
> > +#define EDMA_CTLR_CHAN(ctlr, chan) (((ctlr) << 16) | (chan))
> > +#define EDMA_CTLR(i) ((i) >> 16)
> > +#define EDMA_CHAN(i) ((i) & 0xffff)
> > +
>
> I can't quite think of a word that can mean "channel or slot"
> and is already used in the DMA context. So all I'll do right
> now is note that "CHAN" will be misleading when these are
> used with slot identifiers, so a better tag would be nice.
>
As EDMA_CTLR_CHAN is used only to pass channel numbers, we can
leave it as it is and I am proposing to use EDMA_CHAN_SLOT
instead of EDMA_CHAN to get channel/slot numbers.
Regards, Sudhakar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
