Jorge Luis Zapata Muga <[email protected]> writes:

> On Fri, Apr 17, 2009 at 10:10 PM, Kevin Hilman
> <[email protected]> wrote:
>> Jorge Luis Zapata Muga <[email protected]> writes:
>>
>>> This series of patches add support for the Neuros Technologies OSD2
>>> board (http://wiki.neurostechnology.com/index.php/OSD_2.0_HD). It is a
>>> multimedia player/recorder based on DM6446.
>>>
>>> Sorry for the noise about sending the patches too many times,
>>> hopefully this will be the last time :)
>>>
>>> Signed-off-by: Jorge Luis Zapata <[email protected]>
>>> ---
>>>  arch/arm/mach-davinci/Kconfig             |    8 +++++
>>>  arch/arm/mach-davinci/Makefile            |    1 +
>>>  arch/arm/mach-davinci/board-ntosd_644xa.c |   45 
>>> +++++++++++++++++++++++++++++
>>>  3 files changed, 54 insertions(+), 0 deletions(-)
>>>  create mode 100644 arch/arm/mach-davinci/board-ntosd_644xa.c
>>>
>>> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
>>> index 05a80ca..e359a8c 100644
>>> --- a/arch/arm/mach-davinci/Kconfig
>>> +++ b/arch/arm/mach-davinci/Kconfig
>>> @@ -53,6 +53,14 @@ config MACH_SFFSDR
>>>         Say Y here to select the Lyrtech Small Form Factor
>>>         Software Defined Radio (SFFSDR) board.
>>>
>>> +config MACH_NTOSD_644XA
>>> +     bool "Neuros OSD (644x Revision A)"
>>> +     default n
>>> +     depends on ARCH_DAVINCI_DM644x
>>> +     help
>>> +       Configure this option to use Neuros OSD dm644x revision A
>>> +          hardware
>>> +
>>>  config DAVINCI_MUX
>>>       bool "DAVINCI multiplexing support"
>>>       depends on ARCH_DAVINCI
>>> diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile
>>> index b3bb132..2e9656c 100644
>>> --- a/arch/arm/mach-davinci/Makefile
>>> +++ b/arch/arm/mach-davinci/Makefile
>>> @@ -19,4 +19,5 @@ obj-$(CONFIG_CP_INTC)                       += cp_intc.o
>>>  obj-$(CONFIG_MACH_DAVINCI_EVM)       += board-dm644x-evm.o
>>>  obj-$(CONFIG_MACH_DAVINCI_DM646X_EVM)        += board-dm646x-evm.o
>>>  obj-$(CONFIG_MACH_DAVINCI_DM355_EVM) += board-dm355-evm.o
>>> +obj-$(CONFIG_MACH_NTOSD_644XA)               += board-ntosd_644xa.o
>>>  obj-$(CONFIG_MACH_SFFSDR)            += board-sffsdr.o
>>
>> The names chosen here are a bit confusing.  AFAIK, there isn't a SoC
>> named dm6446A and it looks like the 'A' is actually the rev. A of the
>> board, right?  IIUC, the board is actually called the Neuros OSD2,
>> right?
>>
>
> I think the 'a' comes from the dm6446 chip revision, i agree the name
> was not picked up correctly
>
>> So rather than putting the SoC in the board name, how about
>>
>>  config MACH_NEUROS_OSD2
>>
>> and name the board file board-neuros-osd2.c
>
> Yes, i would have preferred to do so, but for some reason the machine
> name that was registered is ntosd_644xa. So i wanted to keep the same
> names all over the place and use the same uboot number.

Please change the registered name.  It is not hard to do.

Kevin



_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to