Laurent, > >In practice most applications will QBUF before STREAMON. You can fix the >QBUF- >after-STREAMON case later (please add a comment to the code) but you should >already make sure the driver will not crash if QBUF hasn't been called >before >STREAMON. As a general rule, non-implemented functions will not prevent >your >driver from going upstream, but crashes will likely be show-stoppers. >Please >mark non-implemented functions with a TODO comment in the code so that >people >can start hacking once the driver is committed. > [MK]. Looks good to me. The driver will not crash, but gives an error to application. I have tested this scenario. >[snip] > >Best regards, > >Laurent Pinchart >
_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
