Russell King - ARM Linux <[email protected]> writes:

> On Fri, May 15, 2009 at 05:46:10PM -0700, Kevin Hilman wrote:
>> diff --git a/arch/arm/boot/compressed/head-davinci.S 
>> b/arch/arm/boot/compressed/head-davinci.S
>> new file mode 100644
>> index 0000000..4a269e9
>> --- /dev/null
>> +++ b/arch/arm/boot/compressed/head-davinci.S
>> @@ -0,0 +1,19 @@
>> +/*
>> + * DaVinci (and relatives) specific tweaks.
>> + * This is merged into head.S by the linker.
>> + */
>> +
>> +#include <linux/linkage.h>
>> +#include <asm/mach-types.h>
>> +
>> +            .section        ".start", "ax"
>> +
>> +__davinci_start:
>> +            /* Save machine number for later conditional code */
>> +            adr     r0, davinci_machine_no
>> +            str     r7, [r0]
>> +
>> +            .text
>> +            .globl  davinci_machine_no
>> +davinci_machine_no:
>> +            .word   0x00000000
>
> There's really no need for this (and please don't contaminate .text with
> writable data - that breaks decompressor-in-flash.)
>
> We save the passed ID to __machine_arch_type, so the normal mach-types.h
> stuff will work as normal.

OK, will use __machine_arch_type in v2.  Mark has already sent me
an updated version of this implementing your suggestion.

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to