Russell King - ARM Linux <[email protected]> writes: > On Fri, May 15, 2009 at 05:58:19PM -0700, Kevin Hilman wrote: >> +static struct davinci_soc_info davinci_soc_info; >> + >> +struct davinci_soc_info *davinci_get_soc_info(void) >> +{ >> + return &davinci_soc_info; >> +} >> +EXPORT_SYMBOL(davinci_get_soc_info); > > Another point - there's not much point having this function, it provides > no additional benefit over referencing davinci_soc_info directly. > (It's actually a penalty because the overhead of calling it will be > far higher than accessing the structure directly.) > > It only makes sense if you plan to do something in this function, but > then it'll make things like the soc type selection stuff more heavy.
Any objection to keeping an inline accessor function in <mach/common.h> This allows current code to work, but eliminates the function call overhead. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
