On Wed, Jun 03, 2009 at 12:28:27PM -0700, Kevin Hilman wrote:
> "Mark A. Greer" <[email protected]> writes:
> 
> > From: Mark A. Greer <[email protected]>
> >
> > The davinci timer code currently references the watchdog timer's
> > device structure and the base address for the WDT.  However,
> > the device structure is referenced by directly accessing the WDT's
> > platform_data and the base address is referenced via the soc_info
> > structure.  Instead of having two separate ways of accessing
> > WDT info, put a pointer to the WDT's platform_data in the soc_info
> > structure and get both pieces of information through it.
> 
> [sorry for the lag]
> 
> Rather than adding the pdev to soc_info, any objections to just
> dropping watchdog from soc_info all together (patch below.)  It's
> basically like yours, except I just access the pdev directly in the
> reset code instead of via soc_info.

Sure, I'm fine with that & your patch.

> I'm leaning towards keeping all non-core drivers out of soc_info
> and using some type of init/register hooks instead.

Yeah, me too.

Mark
--

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to