On Sunday 14 June 2009, Hans Verkuil wrote:
> > +#define dump_reg(sd, reg, val)                               \
> >       do {                                                    \
> > -             val = tvp514x_read_reg(client, reg);            \
> > -             v4l_info(client, "Reg(0x%.2X): 0x%.2X\n", reg, val); \
> > +             val = tvp514x_read_reg(sd, reg);                \
> > +             v4l2_info(sd, "Reg(0x%.2X): 0x%.2X\n", reg, val); \
> >       } while (0)
> 
> Why not turn this into a static inline function? Much better than a macro.

IMO, too big for either.  Make it a real function.


_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to