________________________________________ From: David Brownell [[email protected]] Sent: Sunday, June 21, 2009 2:00 PM To: [email protected] Cc: Paulraj, Sandeep Subject: Re: [RFC][PATCH] DM365 Keypad Support
On Sunday 21 June 2009, [email protected] wrote: > In the mean while i'd like comments on the driver itself. CC drivers/input/keyboard/dm365evm_keypad.o drivers/input/keyboard/dm365evm_keypad.c: In function 'dm365_kp_probe': drivers/input/keyboard/dm365evm_keypad.c:112: warning: unused variable 'val' :) [Sandeep] This is the variable i use to manipulate the val written to the CPLD register. I used this. When i removed references to CPLD functions while submitting the patch, i just left it in. > Since it is DM365 EVM specific, i add all the structures in > the board specific file rather than the DM365 SOC file Look at how the OMAP drivers handle this. It should *NOT* be a board-specific driver. Use platform_data to feed in a table that maps scan codes (from the hardware) to symbolic keycodes. [Sandeep] OK. i will take a look The next dm365 board should be able to re-use this driver and just feed it a different table. [Sandeep] OK. This is a different situation from the dm355 keypad, which is highly specific to that board's msp430 firmware. [Sandeep] Yes - Dave _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
