On Mon, Jul 06, 2009 at 21:23:47, Sergei Shtylyov wrote: > Hello. > > Sekhar Nori wrote: > > > add basic cpufreq support for DA850/OMAP-L138 > > > Currently, frequency scaling only on PLL0 is supported. No scaling of PLL1 > > or voltage levels as yet. > > > This patch also moves Async3 clock source to PLL1 so that frequency scaling > > on PLL0 does not affect those peripherals. Without this the console on UART2 > > goes for a toss the moment CPUFreq kicks in. > > > The OPP defintions assume clock input of 24MHz to the SoC. This is inline > > with hardcoding of input frequency in the <soc>.c files. At some point > > this will need to move into board dependent code as boards appear with > > different input clock. > > > Tested with ondemand governer and a shell script to vary processor load. > > > Signed-off-by: Sekhar Nori <[email protected]> > > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c > > index 274f004..7a3a376 100644 > > --- a/arch/arm/mach-davinci/da850.c > > +++ b/arch/arm/mach-davinci/da850.c > > @@ -15,6 +15,7 @@ > > #include <linux/init.h> > > #include <linux/clk.h> > > #include <linux/platform_device.h> > > +#include <linux/cpufreq.h> > > > > #include <asm/mach/map.h> > > > > @@ -32,14 +33,20 @@ > > > > #define DA850_PSC0_BASE 0x01c10000 > > #define DA850_PLL0_BASE 0x01c11000 > > -#define DA850_JTAG_ID_REG 0x01c14018 > > #define DA850_TIMER64P0_BASE 0x01c20000 > > #define DA850_TIMER64P1_BASE 0x01c21000 > > #define DA850_GPIO_BASE 0x01e26000 > > #define DA850_PSC1_BASE 0x01e27000 > > #define DA850_PLL1_BASE 0x01e1a000 > > Please don't duplicate these #define's which are not specific to DA850 > and are the same for DA830. Could you move them into soime header file > instead -- probably <mach/hardware.h>? >
Sergei, The above lines were added by my DA850/OMAP-L138 SoC and EVM patches. I'll move them to mach/da8xx.h file when I submit my next version of the patches. Kevin, Do you have any objections to moving these #defines to mach/da8xx.h file as they'll be common across DA830/OMAP-L137 and DA850/OMAP-L138? Regards, Sudhakar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
