On Thu, Jul 09, 2009 at 07:44:34AM -0700, Kevin Hilman wrote:
> Sergei Shtylyov <[email protected]> writes:
> 
> > Hello.
> >
> > Kevin Hilman wrote:
> >
> >> Signed-off-by: Kevin Hilman <[email protected]>
> >>   
> >
> > [...]
> >
> >> diff --git a/arch/arm/mach-davinci/include/mach/debug-macro.S 
> >> b/arch/arm/mach-davinci/include/mach/debug-macro.S
> >> index 69837a6..642f000 100644
> >> --- a/arch/arm/mach-davinci/include/mach/debug-macro.S
> >> +++ b/arch/arm/mach-davinci/include/mach/debug-macro.S
> >> @@ -26,7 +26,7 @@
> >>            movne   \rx, #0xfe000000        @ virtual base
> >>  #if defined(CONFIG_ARCH_DAVINCI_DA8XX) && defined(CONFIG_ARCH_DAVINCI_DMx)
> >>  #error Cannot enable DaVinci and DA8XX platforms concurrently
> >> -#elif defined(CONFIG_MACH_DAVINCI_DA8XX_EVM)
> >> +#elif defined(CONFIG_ARCH_DAVINCI_DA8XX)
> >>   
> >
> >   Er, debug UART depends on the board, not SoC. 
> 
> True, but so far both da8xx EVMs use the same UART, so I removed
> the board-specific parts making it SoC specific.
> 
> If we need to eventually make this board-specific, I'd rather not do it
> with #ifdefs.

Yes, the '_EVM' was very intentional but you do have a good point.

Mark
--

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to