Mark Brown <[email protected]> writes: > On Mon, Jul 13, 2009 at 02:50:41PM -0700, Kevin Hilman wrote: > >> - dev->clk = clk_get(&pdev->dev, pdata->clk_name); >> + dev->clk = pdata->clk; > > I've applied the first two but as I said in response to your previous > mail this doesn't seem like the way the clock API should be used. I can > apply this if required but it'd seem better to fix things up to use the > clock API abstraction here to cut down on the amount of cross tree > issues in the future if possible.
There are two solutions to this. 1) this proposal 2) go back to the original one where we used: dev->clk = clk_get(&pdev->dev, NULL); and simply rely on the fact that the platform setup code sets up the clkdev nodes to have the "soc-audio" string in them instead of the physical clock names. This was how it currently is in mainline, but when the dm6467 changes were merged the change was made to pass clock names in platform data, which is not acceptable on the ARM upstream side. Personally, I prefer (2), but was under the impression that it was not liked on the ASoC side. I'll gladly switch things back to using (2) if that's OK on ASoC side. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
