Hello.

Kevin Hilman wrote:

DM646x has MUSB connected to IRQs 13 and 14 (unlike IRQ12 on other platforms),
so pass the correct IRQ resources with the platform device.

Signed-off-by: Dmitry Krivoschekov <[email protected]>
Signed-off-by: Sergei Shtylyov <[email protected]>

---
The patch has been reworked based on Kevin's suggestion.
I've nearly forgotten about it... :-)

Looks good, except needs some whitespace cleanup, checkpatch reports:

ERROR: code indent should use tabs where possible
#72: FILE: arch/arm/mach-davinci/usb.c:94:
+ ^I^I/* Override the defaults as DM6467 uses different IRQs. */$

ERROR: code indent should use tabs where possible
#73: FILE: arch/arm/mach-davinci/usb.c:95:
+ ^I^Iusb_dev.resource[1].start = IRQ_DM646X_USBINT;$

ERROR: code indent should use tabs where possible
#74: FILE: arch/arm/mach-davinci/usb.c:96:
+ ^I^Iusb_dev.resource[2].start = IRQ_DM646X_USBDMAINT;$

total: 3 errors, 0 warnings, 31 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

   Oops, must be a result of resolving reject. :-<

WBR, Sergei

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to