> -----Original Message----- > From: vimal singh [mailto:[email protected]] > Sent: Friday, July 17, 2009 2:33 AM > To: Narnakaje, Snehaprabha > Cc: [email protected]; davinci-linux-open- > [email protected]; [email protected]; [email protected]; > [email protected]; Paulraj, Sandeep > Subject: Re: [PATCH v3 1/3] mtd-nand: Add "page" parameter to all > read_page/read_page_raw APIs > > On Fri, Jul 17, 2009 at 3:29 AM, <[email protected]> wrote: > > From: Sneha Narnakaje <[email protected]> > > > > This patch new "page" parameter to all NAND read_page/read_page_raw > APIs. > > The read_page API for the new mode ECC_HW_OOB_FIRST requires the page > > information to send the READOOB command and read the OOB area before the > > data area. > > > > This patch series applies to linux-mtd next (mmotm) GIT tree. > > This patch is the same as v2 version of this patch. > > > > Reviewed-by: David Brownell <[email protected]> > > Signed-off-by: Sneha Narnakaje <[email protected]> > > Signed-off-by: Sandeep Paulraj <[email protected]> > > --- > > drivers/mtd/nand/atmel_nand.c | 2 +- > > drivers/mtd/nand/cafe_nand.c | 2 +- > > drivers/mtd/nand/fsl_elbc_nand.c | 3 ++- > > drivers/mtd/nand/nand_base.c | 18 ++++++++++-------- > > drivers/mtd/nand/sh_flctl.c | 2 +- > > include/linux/mtd/nand.h | 4 ++-- > > 6 files changed, 17 insertions(+), 14 deletions(-) > > > > Why not just adding 'page' or 'cur_page' parameter to 'mtd_info' structure > and > populate the same in 'nand_do_read_ops' and 'nand_do_write_ops' as soon as > you > calculate 'page' for every read and write access respectivily. And then > this > info can be used by any one who has knowledge of 'mtd_info'.
Yes, that was one option. This meant, some of the existing handlers for read_oob and write_oob required changes to get rid of "page", if we decide to use the page from mtd_info structure. Thanks Sneha > > -vimal > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
