Thank you for the suggestion. I'll submit the patch again with the desired changes.
Thanks and regards, ~Vipin > -----Original Message----- > From: David Brownell [mailto:[email protected]] > Sent: Wednesday, July 22, 2009 3:25 PM > To: [email protected]; Vipin Bhandari > Subject: Re: [PATCH] davinci: Correct ro and cd feature in DM355 > > On Tuesday 21 July 2009, Vipin Bhandari wrote: > > This patch corrects the support for MMCSD card detection > > and read only feature for SoC DM355. > > > > Signed-off-by: Vipin Bhandari <[email protected]> > > --- > > This patch has been tested on DM355 EVM. > > > I don't follow. It does seem like some indices in > the current driver, drivers/mfd/dm355evm_msp.c, may > need to swap ... but why would a patch changing two > lines of code need to get blown up into > > > > > arch/arm/mach-davinci/board-dm355-evm.c | 107 > +++++++++++++++++++++++------- > > 1 files changed, 82 insertions(+), 25 deletions(-) > > .... 107 lines of changes, breaking the RTC and IR/Remote > drivers in the process???? > > NAK on this patch. > > It looks like you should only need to swap two index > pairs in the drivers/mfd code, and add a comment about > how the docs are wrong. > > - Dave > > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
