"Sudhakar Rajashekhara" <[email protected]> writes:
> On Fri, Aug 14, 2009 at 04:51:05, Kevin Hilman wrote:
>> Sudhakar Rajashekhara <[email protected]> writes:
>>
>> > On DA850/OMAP-L138 EVM, MMC/SD and NOR Flash share
>> > some of the AEMIF pins. This patch prints out a warning
>> > during booting, if both MMC/SD and NOR Flash are enabled
>> > in kernel menuconfig.
>> >
>> > If both MMC/SD and NOR Flash are enabled, only MMC/SD
>> > will work correctly.
>> >
>> > Signed-off-by: Sudhakar Rajashekhara <[email protected]>
>> > ---
>> > This patch is dependent on the following patches which
>> > I have submitted earlier:
>> > [PATCH] davinci: Macro to convert GPIO signal to GPIO pin number
>> > [PATCH v3] davinci: Add platform support for da850/omap-l138 GLCD
>> > [PATCH v3] davinci: Add MMC/SD support for da850/omap-l138
>> > [PATCH v3] davinci: Add NAND flash support for DA850/OMAP-L138
>> > [PATCH v3] davinci: Add NOR flash support for da850/omap-l138
>>
>> FYI for future reference. When you have lots of patch dependencies
>> like this, it is simpler to send them as a series. If you use
>> git-format-patch for a range of commits, it will automatically do
>> the 'PATCH x/y' formatting etc.
>>
>
> In this case, in the series if one patch needs modifications
> then do I need to re-submit the whole series again?
Usually, just resubmitting the changed patch is all that is needed,
unless of course it affects code changed by later patches.
[...]
>> > + if (HAS_MMC) {
>> > + if (HAS_NOR)
>> > + pr_warning("WARNING: both NOR Flash and MMC/SD are "
>> > + "enabled, but they share AEMIF pins.\n"
>> > + "\tDisable one of them.\n");
>> > +
>>
>> Hmm, this isn't quite right. MMC will never be configured unless NOR
>> is enabled also.
>>
>
> This is not the case now. MMC will get initialized even if NOR is
> not enabled. If the second if condition is true it only prints the
> warning and proceeds to initialize MMC.
You're right, sorry for the noise.
Pushed along with the others just now.
Kevin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
