Hi,

I will send v2 as you suggested.

Thanks.
-
Hemant
 
> -----Original Message-----
> From: Sergei Shtylyov [mailto:[email protected]]
> Sent: Sunday, August 30, 2009 5:41 PM
> To: Pedanekar, Hemant
> Cc: [email protected]
> Subject: Re: [PATCH] davinci: dm646x-evm: Add platform data for NAND
> 
> Hello.
> 
> Hemant Pedanekar wrote:
> 
> > This patch adds platform data and partition info for NAND on dm6467 EVM.
> >
> > Note that the partition layout is dependent on the UBL, U-Boot
> combination used.
> > This patch uses partition organization suitable with latest U-Boot of
> LSP 1.3.
> > For example, U-Boot environment goes in block 0, UBL resides in block
> form 1 to
> > 5 and so on.
> >
> > Signed-off-by: Hemant Pedanekar <[email protected]>
> >
> [...]
> > diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-
> davinci/board-dm646x-evm.c
> > index 434253e..f349e4d 100644
> > --- a/arch/arm/mach-davinci/board-dm646x-evm.c
> > +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
> >
> [...]
> > @@ -45,6 +49,7 @@
> >  #include <mach/psc.h>
> >  #include <mach/serial.h>
> >  #include <mach/i2c.h>
> > +#include <mach/nand.h>
> >  #include <mach/mmc.h>
> >  #include <mach/emac.h>
> >
> > @@ -55,6 +60,18 @@
> >  #define HAS_ATA 0
> >  #endif
> >
> > +#if defined(CONFIG_MTD_NAND_DAVINCI) || \
> > +    defined(CONFIG_MTD_NAND_DAVINCI_MODULE)
> > +#define HAS_NAND 1
> > +#else
> > +#define HAS_NAND 0
> > +#endif
> > +
> > +#define DAVINCI_ASYNC_EMIF_CONTROL_BASE            0x20008000
> > +#define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE   0x42000000
> > +
> > +#define NAND_BLOCK_SIZE            SZ_128K
> > +
> >  /* CPLD Register 0 bits to control ATA */
> >  #define DM646X_EVM_ATA_RST         BIT(0)
> >  #define DM646X_EVM_ATA_PWD         BIT(1)
> >
> 
> [...]
> 
> > @@ -645,6 +725,9 @@ static __init void evm_init(void)
> >     dm646x_init_mcasp0(&dm646x_evm_snd_data[0]);
> >     dm646x_init_mcasp1(&dm646x_evm_snd_data[1]);
> >
> > +   if (HAS_NAND)
> >
> 
>    This check is not really needed. Tghe platform device should exist
> regrdless of whether its driver is enabled or not.
> 
> > +           platform_device_register(&davinci_nand_device);
> >
> 
> WBR, Sergei
> 
> 

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to