[email protected] writes:

> From: Sandeep Paulraj <[email protected]>
>
> The patch does the following
>
> 1) The edma_alloc_cont_slots API is used for obtaining a set of
> contiguous slots. When we use the "_ANY" option with this
> API, by definition of this option it is suppossed to start
> looking for a set of contiguous slots starting from slot 64 for
> DaVinci SOC's and 32 for Primus. This has been explained in
> the API description in the driver itself. So when we use the
> "_ANY" option with this API, the slot number passed as
> an argument should be a "don't care".
> This patch takes care of this condition mentioned above.
> When checking to see if the starting slot is a valid number,
> it checks to make sure that the "_ANY" option is not used.
>
> 2) In the reserve contiguous params function, break statement
> was incorrectly implemented
>
> 3) The reserve_contiguous_params function is a remnant of past TI
> LSP releases. It should be named reserve_contiguous_slots. The API
> description and the function is also being appropriately changed so 
> that we use the word 'slot" instead of "param".
>
> 4) In the edma_free_cont_slots API, the variable slot was being modified
> and then used in the for loop, so we end up in a never ending loop.
>
> Signed-off-by: Sandeep Paulraj <[email protected]>

This patch should be broken up along the lines of your 1-4 list above.  This
helps reviewers be sure which parts are part of which change.

Also, tqhe bugfixes ones can be queued for the 2.6.31-rc cycle and the others
will be queued for 2.6.32.

Thanks,

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to