+     /* Enable Keyscan module and enable */
+     davinci_ks_write(davinci_ks, DAVINCI_KEYSCAN_AUTODET |
DAVINCI_KEYSCAN_KEYEN,
+                     DAVINCI_KEYSCAN_KEYCTRL);
We seem to be hardcoded to the 4x4 matrix type here.
Some DM365 boards could use 5x3 matrix.

Thanks,
Sekhar

[MA] I will add a platform option for matrix type to choose 4x4 or 5x3
matrix.
What do think about this?

Sounds good. I am not sure if any other piece of code
needs to change though.
The strobe and interval have to change.  Afcourse that change comes into the 
picture only when the mode is changed from 4x4 to 5x3.
I can see that there are options given for this in board specific code.
Thanks,
Sekhar

Thanks,
Sandeep


struct davinci_ks_platform_data {
        unsigned short  *keymap;
        u32             keymapsize;
        u32             rep:1;
        u32             strobe;
        u32             interval;
+       u32             matrix_type;
};

I will add something like this, so from the board specific code you can define strobe, interval and matrix type.

Thanks,

Miguel Aguilar

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to