Kevin Hilman wrote:
Chaithrika U S <[email protected]> writes:

DA850/OMAP-L138 EVM has a RMII Ethernet PHY on the UI daughter card. The PHY
is enabled by proper programming of the IO Expander (TCA6416) ports. Also for
RMII PHY to work, the MDIO clock of MII PHY has to be disabled since both the
PHYs have the same address. This is done via the GPIO2[6] pin. This patch adds
support for RMII PHY.

This patch also adds a menuconfig option to select UI card and peripherals
present on it. Currently, the only sub-option in this menu is RMII.
This menuconfig option is similar to the one present for UI card on
DA830/OMAP-L137 EVM.

Signed-off-by: Chaithrika U S <[email protected]>

Looks good, a couple Kconfig questions/comments below...

---
 arch/arm/mach-davinci/Kconfig              |   24 +++++
 arch/arm/mach-davinci/board-da850-evm.c    |  148 +++++++++++++++++++++++++++-
 arch/arm/mach-davinci/da850.c              |   17 +++
 arch/arm/mach-davinci/include/mach/da8xx.h |    1 +
 arch/arm/mach-davinci/include/mach/mux.h   |    9 ++
 5 files changed, 194 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 7b6dddf..665e7b1 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -129,6 +129,30 @@ config MACH_DAVINCI_DA850_EVM
        help
          Say Y here to select the TI DA850/OMAP-L138 Evaluation Module.
+config DA850_UI_EXP
+       bool "DA850/OMAP-L138 UI (User Interface) board expander configuration"
+       depends on MACH_DAVINCI_DA850_EVM

For the GPIO expander, it probably makes sense to automatically enable the
GPIO expander driver too by adding the following here:

     select CONFIG_GPIO_PCA953X


FYI, my da830 doesn't have a UI board, and when I manually enabled the pca953x driver, I got this upon probe:

pca953x 1-0020: failed reading register pca953x: probe of 1-0020 failed with error -121

Based on earlier discussions, I gathered that this IO expander is physically on the UI board. Based on this, couldn't we use this information to do runtime detection of the UI board? Until the setup hook is called, assume there is no UI board.

Just a thought...

Kevin




_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to