On Fri, Oct 02, 2009 at 02:24:17, Mark A. Greer wrote: > On Thu, Oct 01, 2009 at 11:32:01PM +0530, Sekhar Nori wrote: > > This patch simplifies selection of peripherals on the UI card by > > eliminating the DA830_UI config option. Instead, the successful > > probe of GPIO expander present on the UI card is used to detect > > its presence. For this reason, GPIO_PCF857X is auto-selected when > > DA830 EVM is configured. In case the UI card is absent, the probe > > fails in reasonable time. > > > > The choice menu for UI card peripheral selection is eliminated in > > favor of using the driver config item itself to configure the IO > > expander. > > > > This has the advantage of users not needing to select the peripheral > > from System menu after selecting the driver from the Device drivers > > menu. As a bonus, this also removes the non-intuitive need to select > > DA830_UI_LCD to get the MMC/SD on the DSK board working with the UI > > card plugged in. > > > > Signed-off-by: Sekhar Nori <[email protected]> > > --- > > I don't know Sekhar... This looks like a step backwards to me with all > the #ifdef-ery. Why not keep the code as it is and change the #ifdefs > that are already there (e.g., change the CONFIG_UI ones to CONFIG_FB, > etc)?
Mark, The only new #ifdef the patch introduces is for MMC/SD. That is to make sure plugging in UI card does not get MMC to stop working. I think the patch actually improves readability by removing the existing #ifdefs present inside function body. The HAS_XXX constructs are not new and have been used in other DaVinci code. Have a look at support for DM644x EVM here: http://lxr.linux.no/linux+v2.6.31/arch/arm/mach-davinci/board-dm644x-evm.c#L609 Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
