"Nori, Sekhar" <nsek...@ti.com> writes: > On Tue, Oct 20, 2009 at 00:03:11, Kevin Hilman wrote: >> Russell King - ARM Linux <li...@arm.linux.org.uk> writes: >> >> > On Fri, Oct 16, 2009 at 12:09:42PM -0700, Kevin Hilman wrote: >> >> From: Sekhar Nori <nsek...@ti.com> >> >> >> >> include/mach/system.h uses the cpu_do_idle() function which is >> >> defined in asm/proc-fns.h. Without this patch including system.h >> >> leads to error of the sort: >> >> >> >> error: implicit declaration of function 'cpu_do_idle' >> > >> > The right answer might actually be to ensure that arch/arm/kernel/process.c >> > includes this file, so that all mach/system.h files don't have to. >> >> Maybe it should be more explicit, but at least on 2.6.32, process.c >> already triggers an include of <asm/proc-fns.h> (linux/mm.h -> >> asm/pgtable.h -> asm/proc-fns.h. >> >> IIRC, the problem was not with arch/arm/kernel/process.c other >> mach-davinci files using <mach/system.h> for some reason. >> >> After Sergei's major #include cleanup for mach-davinci/*, I don't >> think this is actually necessary anymore. >> >> Sekhar, I'll drop this patch from davinci-next unless you think this >> is still necessary for some reason. > > Kevin, I made this patch because I started using arch_idle() for entering > WFI mode in the da850 cpuidle driver. > > The Marvell Kirkwood cpuidle driver uses a call to cpu_do_idle() directly, > but calling arch_idle sounded more appropriate to me in case the arch > needs to do something special for entering idle (though not actually the > case with da850).
For now, I think we should stick to calling cpu_do_idle() directly. Kevin _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
