>> - /*
>> - * setup Mux configuration for vpfe input and register
>> - * vpfe capture platform device
>> - */
>> - davinci_cfg_reg(DM355_VIN_PCLK);
>> - davinci_cfg_reg(DM355_VIN_CAM_WEN);
>> - davinci_cfg_reg(DM355_VIN_CAM_VD);
>> - davinci_cfg_reg(DM355_VIN_CAM_HD);
>> - davinci_cfg_reg(DM355_VIN_YIN_EN);
>> - davinci_cfg_reg(DM355_VIN_CINL_EN);
>> - davinci_cfg_reg(DM355_VIN_CINH_EN);
>[Hiremath, Vaibhav] Why have you removed mux configuration from here and
>moved to CCDC driver? Any specific reason?
>
Good catch. I wanted to do this clean up, but missed it. Actually platform data
should have a function setup_pinmux() to set up the pin mux for the
ccdc input. This function will be defined in the platform file and will be
called during probe()
Murali
>> + platform_device_register(&dm355_ccdc_dev);
>> platform_device_register(&vpfe_capture_dev);
>>
>> return 0;
>> diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-
>> davinci/dm644x.c
>> index 2cd0081..982be1f 100644
>> --- a/arch/arm/mach-davinci/dm644x.c
>> +++ b/arch/arm/mach-davinci/dm644x.c
>> @@ -612,6 +612,11 @@ static struct resource vpfe_resources[] = {
>> .end = IRQ_VDINT1,
>> .flags = IORESOURCE_IRQ,
>> },
>> +};
>> +
>> +static u64 vpfe_capture_dma_mask = DMA_BIT_MASK(32);
>> +static struct resource dm644x_ccdc_resource[] = {
>> + /* CCDC Base address */
>> {
>> .start = 0x01c70400,
>> .end = 0x01c70400 + 0xff,
>> @@ -619,7 +624,17 @@ static struct resource vpfe_resources[] = {
>> },
>> };
>>
>> -static u64 vpfe_capture_dma_mask = DMA_BIT_MASK(32);
>> +static struct platform_device dm644x_ccdc_dev = {
>> + .name = "dm644x_ccdc",
>> + .id = -1,
>> + .num_resources = ARRAY_SIZE(dm644x_ccdc_resource),
>> + .resource = dm644x_ccdc_resource,
>> + .dev = {
>> + .dma_mask = &vpfe_capture_dma_mask,
>> + .coherent_dma_mask = DMA_BIT_MASK(32),
>> + },
>> +};
>> +
>> static struct platform_device vpfe_capture_dev = {
>> .name = CAPTURE_DRV_NAME,
>> .id = -1,
>> @@ -772,6 +787,7 @@ static int __init dm644x_init_devices(void)
>> platform_device_register(&dm644x_edma_device);
>> platform_device_register(&dm644x_emac_device);
>> platform_device_register(&dm644x_vpss_device);
>> + platform_device_register(&dm644x_ccdc_dev);
>> platform_device_register(&vpfe_capture_dev);
>>
>> return 0;
>> --
>> 1.6.0.4
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
