Sekhar Nori <[email protected]> writes: > DM6467T (T for Turbo) is a newer and faster DM6467 > part from TI. The new part supports 1080p video and > has the ARM running at 495MHz. More SoC information: > > http://focus.ti.com/docs/prod/folders/print/tms320dm6467t.html > > Spectrum Digital, Inc has a new EVM for this part. > It is _mostly_ same as the older DM6467 EVM except > for a 33MHz crystal input and THS8200 video encoder > for 1080p support. > > The meat of this patch is dedicated to initializing > the crystal frequency from EVM board file. > > Additional notes: > I did consider some alternative ways to make the crystal > input board specific including - (1) having board code > initialize the crystal frequency using the first member > of soc_info->cpu_clks array (2) introducing a new ref_clk_rate > member in soc_info structure. > > But, the current way seems to be the simplest and least > intruding considering that both the clock array and SoC > info structure are actually private to the SoC file. Also > the fact that davinci_common_init() initializes both the > soc_info and clocks in one go. > > Signed-off-by: Sekhar Nori <[email protected]>
This approach seems fine to me. Some minor comments below... > --- > This patch needs updated mach-types file for building. > Get it from here: http://www.arm.linux.org.uk/developer/machines/download.php You could also send a patch with just the new mach-type added. I will include it in davinci git and will drop it as soon as the new mach-types changes hit upstream. > arch/arm/mach-davinci/Kconfig | 4 ++++ > arch/arm/mach-davinci/board-dm646x-evm.c | 24 ++++++++++++++++++++++++ > arch/arm/mach-davinci/dm646x.c | 3 +-- > arch/arm/mach-davinci/include/mach/dm646x.h | 2 ++ > 4 files changed, 31 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig > index 033bfed..0ebe185 100644 > --- a/arch/arm/mach-davinci/Kconfig > +++ b/arch/arm/mach-davinci/Kconfig > @@ -91,10 +91,14 @@ config MACH_DAVINCI_DM6467_EVM > bool "TI DM6467 EVM" > default ARCH_DAVINCI_DM646x > depends on ARCH_DAVINCI_DM646x > + select MACH_DAVINCI_DM6467TEVM > help > Configure this option to specify the whether the board used > for development is a DM6467 EVM > > +config MACH_DAVINCI_DM6467TEVM > + bool > + I think you should add a comment here about the fact that this is always auto-selected when DM6467 EVM is selected and is required for the machine_is_* stuff to work. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
