On Tue, Dec 08, 2009 at 22:11:01, Kevin Hilman wrote: > "Nori, Sekhar" <[email protected]> writes: > > > On Tue, Dec 08, 2009 at 05:34:41, Kevin Hilman wrote: > >> Sekhar Nori <[email protected]> writes: > >> > > > > [...] > > > >> > diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c > >> > b/arch/arm/mach-davinci/board-dm646x-evm.c > >> > index 6ff3411..5d9283f 100644 > >> > --- a/arch/arm/mach-davinci/board-dm646x-evm.c > >> > +++ b/arch/arm/mach-davinci/board-dm646x-evm.c > >> > @@ -40,6 +40,8 @@ > > > > [...] > > > >> > > >> > +#define CDCE949_XIN_RATE 27000000 > >> > + > >> > +/* CDCE949 support - "lpsc" field is overridden to work as clock number > >> > */ > >> > +static struct clk cdce_clk_in = { > >> > + .name = "cdce_xin", > >> > + .flags = ALWAYS_ENABLED, > >> > >> Why do you need ALWAYS_ENABLED here. I'd rather see > >> clk_get()/clk_enable() used when this clock is required. > >> > > > > This particular clock is just the crystal which feeds > > into the CDCE949. It cannot be enabled/disabled per se. > > This crystal is different from the OSC_IN crystal which > > feeds into the SoC. > > > > However, I do see that none of the reference clocks in > > <soc>.c files are marked as always enabled. So, I will > > remove this. > > OK. The ALWAYS_ENABLED field currently only applies to clocks that have > a valid enable (currently only PSC clocks.)
Hi Kevin, I just sent an update to 5/5 of this series based on this comment. Can you please pull 4/5 from the original series? I did not send that again as there was no change in that. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
