Grant Likely <[email protected]> writes: > On Tue, Jan 5, 2010 at 4:46 PM, Kevin Hilman > <[email protected]> wrote: >> [email protected] writes: >> >>> From: Sandeep Paulraj <[email protected]> >>> >>> This patch adds support for a SPI master driver for the >>> DaVinci series of SOCs >>> >>> Signed-off-by: Sandeep Paulraj <[email protected]> >>> Signed-off-by: Mark A. Greer <[email protected]> >>> Signed-off-by: Philby John <[email protected]> >>> Signed-off-by: Sudhakar Rajashekhara <[email protected]> >> >> Sandeep, >> >> This needs a minor refresh against current Linus tree for the Makefile >> change. >> >> While doing the Makefile addition, it looks like the list is maintained in >> alphabetical order. Please add davinci in the right order, and feel free to >> add my signoff. > > Signed-of-by lines are only for patches that actually pass through > your hands (ie. you add it yourself when you pick it up and pass it). > It is not appropriate to add a s-o-b line for someone else. > "Acked-by" or "Reviewed-by" should be used instead.
Understood. This driver has passed through my hands (and in front of my eyes) in various forms many times in its development, so I figured an s-o-b was appropriate. That being said, for this particular version, and ack is probably more appropriate. Sandeep, after you refresh, please add Acked-by: Kevin Hilman <[email protected]> _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
