Hi Kevin,
I have tried sending the patch again using git send-email. Hope it should be
in a good shape now. Thank you for the patience and the suggestions.
-raghav

On Wed, Jan 6, 2010 at 3:59 AM, Kevin Hilman <[email protected]>wrote:

> Kevin Hilman wrote:
>
>> raghav n <[email protected]> writes:
>>
>>  [PATCH 1/1] MMC: DaVinci: Fixed typos in comments of the response
>>> registers in davinci_mmc.c
>>>
>>
>> You don't need to duplicate the subject in the changelog.
>>
>>  This patch fixes the typos in the comments for the MMC response
>>> registers. They were all /* Response Register 0 and 1 */
>>>
>>> Signed-off-by: [email protected]
>>>
>>
>> Thanks, will que
>>
>>  ---
>>> From 08e00d18ca5d0c20a9035c631e7fcb5f39c88cb8 Mon Sep 17 00:00:00 2001
>>> From: raghav <[email protected]>
>>>
>>> Date: Tue, 5 Jan 2010 23:57:17 +0530
>>> Subject: [PATCH] Fixed comments for the response registers. They were all
>>> saying Regiser 0 and 1.
>>>
>>
>> You've got duplicate headers/changelog etc. here.
>>
>> I highly recommend using git-format-patch + git-send-email to send
>> patches?
>>
>>  ---
>>>  drivers/mmc/host/davinci_mmc.c |    6 +++---
>>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>
>> The patch itself looks fine.  After cleaning up the changelog, I'll
>> queue for 2.6.33-rc fixes series.
>>
>
> After trying to apply this, the patch is corrupted in other ways and
> doesn't apply cleanly.
>
> Please fix up the patch to apply against current davinci git and resend,
> preferably using git-format-patch + git-send-email.
>
> Kevin
>
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to