anybody?
On Mon, Feb 15, 2010 at 7:14 PM, Sameer Naik <[email protected]> wrote: > Hi, > I have found that while setting the transparency attributes on OSD1 > window the following is done: > > /* since bits_per_pixel = 4, this will truncate the width if it is > * not even. Similarly r->dx will be rounded down to an even pixel. > * ... Do we want to return an error otherwise? > */ > width_bytes = r->width * var->bits_per_pixel / 8; > start = dm->osd1->fb_base + r->dy * info->fix.line_length > + r->dx * var->bits_per_pixel / 8; > > blend = (((u8) r->color & 0xf) << 4) | ((u8) r->color); > while (r->height--) { > start += info->fix.line_length; > memset((void *)start, blend, width_bytes); > } > > As you can see that, in the while loop the 'start' is incremented > before memset is done. Is this correct? Shouldn't memset be done > before incrementing start? > Please comment > > Regards > ~Sameer > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
