In the morning... Nice to know it has been fixed. But I got around it for my testing and hence not blocking for me.
Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: [email protected] >-----Original Message----- >From: Kevin Hilman [mailto:[email protected]] >Sent: Wednesday, March 17, 2010 1:22 PM >To: Karicheri, Muralidharan >Cc: davinci-linux-open-source >Subject: Re: upstream build broken for emac driver > >"Karicheri, Muralidharan" <[email protected]> writes: > >> Hi, >> >> When I build upstream accepted branch of linux-davinci tree maintained by >Kevin, I get following compilation error... I am reverting to master branch. >> >> drivers/net/davinci_emac.c: In function 'emac_dev_xmit': >> drivers/net/davinci_emac.c:1471: error: implicit declaration of function >'dma_ca >> che_maint' >> make[2]: *** [drivers/net/davinci_emac.o] Error 1 >> make[1]: *** [drivers/net] Error 2 >> make: *** [drivers] Error 2 > >When did you try this? > >The davinci-upstream-accepted branch should have the commit below. If >it doesn't, try to re-pull. > >Kevin > > > >Author: Sekhar Nori <[email protected]> 2010-03-09 03:20:37 >Committer: Kevin Hilman <[email protected]> 2010-03-16 13:01:14 >Parent: d4c893e7d670f1fb67812fc36c43942dfb729c42 (davinci: MMC: Pass number >of SG segments as platform data) >Child: ded384babbf02ecbfc67c7b339e2667f7f7c791e (TI DaVinci EMAC: Convert >to dev_pm_ops) >Branches: davinci-upstream-accepted, new-master, remotes/origin/davinci- >upstream-accepted, remotes/origin/master >Follows: v2.6.34-rc1 >Precedes: > > net: davinci emac: use dma_{map, unmap}_single API for cache coherency > > The davinci emac driver uses some ARM specific DMA APIs > for cache coherency which have been removed from kernel > with the 2.6.34 merge. > > Modify the driver to use the dma_{map, unmap}_single() APIs > defined in dma-mapping.h > > Without this fix, the driver fails to compile on Linus's > tree. > > Tested on DM365 and OMAP-L138 EVMs. > > Signed-off-by: Sekhar Nori <[email protected]> _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
