"Nori, Sekhar" <[email protected]> writes: > On Thu, Mar 18, 2010 at 17:09:55, I wrote: >> On Wed, Mar 17, 2010 at 22:48:46, Kevin Hilman wrote: > > [...] > >> > >> > In addition, after looking at this a little closer, the *_edma_info >> > structs in devices-da8xx.c could be __initdata since they are copied >> > during edma_probe() (should be done as a fix before this patch.) The >> > same for the rsv structs in the board files. >> >> Okay, actually the whole EDMA platform device needs to be __initdata. > > ... which is incorrect because platform devices can be accessed > later using sysfs. But, just having just the platform_data as > __initdata is also wrong because a persistent object (platform_device) > holds a reference to it. In this case, we "know" the platform data > will not be used, but the kernel detects it and responds with pesky > warnings with CONFIG_DEBUG_SECTION_MISMATCH=y. So, it doesn't look like > *_edma_info structures can be marked __initdata.
If that's the case, then the copies should be removed from _probe as well, and pointers to original data used. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
