On Wed, Mar 31, 2010 at 20:43:29, Ambrose, Martin wrote:

> Andrew,
> 
> Thanks for the feedback.
> 
> > > +/*
> > > + * Function to wait for vertical sync which for this LCD peripheral
> > > + * translates into waiting for the current raster frame to complete.
> > > + */
> > > +static int fb_wait_for_vsync(struct fb_info *info)
> > > +{
> > > +       struct da8xx_fb_par *par = info->par;
> > > +       wait_queue_t wq;
> > > +       int ret;
> > > +
> > > +       init_waitqueue_entry(&wq, current);
> > 
> > DECLARE_WAITQUEUE() would be more conventional.
> 
> I'll update -- cloned this from some older code I think.

After looking at this further this variable wasn't even used so
I will trim this in upcoming v3 patch.

Regards, 
Martin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to