On Fri, Mar 26, 2010 at 03:13:59, Chemparathy, Cyril wrote: > Added support for tnetv107x evaluation module.
Its odd to see the EVM being added before SoC... > > Signed-off-by: Cyril Chemparathy <[email protected]> > --- [...] > > endchoice > > +config MACH_TNETV107X > + bool "TI TNETV107X Reference Platform" > + default ARCH_DAVINCI_TNETV107X > + depends on ARCH_DAVINCI_TNETV107X ... because of symbols like these which are being used before being defined cause git-bisect to break (although this particular case would be quite harmless). > + help > + Say Y here to select the TI TNETV107X Evaluation Module. > + > config DAVINCI_MUX > bool "DAVINCI multiplexing support" > depends on ARCH_DAVINCI > diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile > index 62c5116..eab4c0f 100644 > --- a/arch/arm/mach-davinci/Makefile > +++ b/arch/arm/mach-davinci/Makefile > @@ -32,6 +32,7 @@ obj-$(CONFIG_MACH_DAVINCI_DM6467_EVM) += > board-dm646x-evm.o cdce949.o > obj-$(CONFIG_MACH_DAVINCI_DM365_EVM) += board-dm365-evm.o > obj-$(CONFIG_MACH_DAVINCI_DA830_EVM) += board-da830-evm.o > obj-$(CONFIG_MACH_DAVINCI_DA850_EVM) += board-da850-evm.o > +obj-$(CONFIG_MACH_TNETV107X) += board-tnetv107x-evm.o > > # Power Management > obj-$(CONFIG_CPU_FREQ) += cpufreq.o > diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c > b/arch/arm/mach-davinci/board-tnetv107x-evm.c > new file mode 100644 > index 0000000..a6bf49c > --- /dev/null > +++ b/arch/arm/mach-davinci/board-tnetv107x-evm.c [...] > +static __init void tnetv107x_evm_board_init(void) > +{ > + int status; > + > + davinci_cfg_reg_list(tnetv107x_sdio1_pins); > + davinci_cfg_reg_list(tnetv107x_uart1_pins); > + davinci_cfg_reg_list(tnetv107x_gpio_pins); > + > + tnetv107x_gpio_init(); > + tnetv107x_edma_init(); > + tnetv107x_serial_init(tnetv107x_serial_pdata); > + > + status = gpio_request(TNETV107X_EVM_MMC_WP_GPIO, "MMC WP\n"); > + if (status < 0) { > + printk(KERN_ERR "cannot open mmcsd write protect gpio %d\n", > + TNETV107X_EVM_MMC_WP_GPIO); > + tnetv107x_evm_mmc_config.get_ro = NULL; > + } else > + gpio_direction_input(TNETV107X_EVM_MMC_WP_GPIO); Use braces on else here.. > + > + status = gpio_request(TNETV107X_EVM_MMC_CD_GPIO, "MMC CD\n"); > + if (status < 0) { > + printk(KERN_ERR "cannot open mmcsd card detect gpio %d\n", > + TNETV107X_EVM_MMC_CD_GPIO); > + tnetv107x_evm_mmc_config.get_cd = NULL; > + } else > + gpio_direction_input(TNETV107X_EVM_MMC_CD_GPIO); ... and here. > + > + platform_add_devices(tnetv107x_evm_devices, > + ARRAY_SIZE(tnetv107x_evm_devices)); No need to mux the CD and WP pins as GPIO pins? Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
