"Chemparathy, Cyril" <[email protected]> writes: > Hi, > >> >> Added on-chip peripheral base addresses so tnetv107x SOC header. >> > >> > There should be no need to define the full >> > list of base addresses in one place because >> > the are typically needed only at only one place >> > (near the resource definition). >> > >> > Just add the define where needed and use it. >> >> Agreed. >> >> These should only ever be used when defining a platform_device or in >> the low-level core code. > > Ok. Please comment on the following approach: > > 1. Move arch/arm/mach-davinci/include/mach/<soc>.h to arch/arm/mach-davinci/: > By doing so, these low-level definitions are restricted to mach-davinci code, > and will not be accessible via "#include <mach/xxx>" from elsewhere in the > kernel code.
No, the header location is fine. The point is that most of the base addresses there do not need to be there. If you compare how its done for the other platforms, only the minimal set of base addresses are defined there. The others are defined directly in the places where the platform_devices are defined. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
